-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update watcher #1888
base: main
Are you sure you want to change the base?
chore: update watcher #1888
Conversation
🤖 SeineSailor Here's a concise summary of the pull request changes: Summary: This pull request updates the Go version to 1.22.0, toolchain to go1.22.3, and bumps dependencies to their latest versions, including k8s.io/api, k8s.io/apimachinery, and k8s.io/client-go. The changes introduce two new dependencies, Key Modifications:
Observations and Suggestions:
|
9e04b82
to
3032f2b
Compare
Signed-off-by: Maryam Tahhan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please hold on for merge as it contains k8s api version bump up. @rootfs, as far as I can remember, we take care for any dep version bump up as it contains k8s api?
Update the watcher implementation to use
NewTypedRateLimitingQueue
and fix the linting issue @ #1852